Fix compiling gsad with libmicrohttp >= 0.9.71 #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libmicrohttp introduced a new enum for their http request handling callback functions. Introducing this new return time causes several compiler warnings and because we are treating warnings as errors the whole gsad compilation did fail with libmicrohttp greater or equal than 0.9.71. This version of libmicrohttp is for example shipped with Ubuntu 20.10. Fixes #2317
Closed
Codecov Report
@@ Coverage Diff @@
## gsa-20.08 #2625 +/- ##
=============================================
+ Coverage 52.76% 53.06% +0.30%
=============================================
Files 1070 1072 +2
Lines 25789 25900 +111
Branches 7312 7399 +87
=============================================
+ Hits 13607 13744 +137
+ Misses 11058 11034 -24
+ Partials 1124 1122 -2
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix compiling gsad with libmicrohttp 0.9.71 and later
Why:
ibmicrohttp 0.9.71 changed the return value of the request handler callback functions. This causes a compiler warning with newer distributions like Ubuntu 20.10. Because we treat warnings as errors (
-Wall) the compilation fails on such systems.How:
Build gsad on Ubuntu 20.10 successfully.
Checklist: